Cannot modify actions [FIXED]

Any feedback, suggestion, bug reports, problems....
Locked
fireattack
Posts: 5
Joined: Sat Jan 27, 2018 7:20 am

Cannot modify actions [FIXED]

Post by fireattack » Sat Jan 27, 2018 7:23 am

Image

The "name" text area is not editable. You can change checkbox and drop down menu for icon click, but the "save" is always grayed out (therefore, can't actually modify).

Did I miss something obvious?

Advertisements

 

User avatar
DaveG
Flagfox Developer
Posts: 717
Joined: Wed Oct 03, 2007 9:06 pm
Location: Philadelphia, USA

Re: Cannot modify actions

Post by DaveG » Sat Jan 27, 2018 11:32 am

See the FAQ on this topic.

If you want to change a default action, you can make a copy to edit (and you can disable the default, if you wish).

I think I may consider adding a link/button to clone the action directly from that dialog, so it's a little more discoverable.

fireattack
Posts: 5
Joined: Sat Jan 27, 2018 7:20 am

Re: Cannot modify actions

Post by fireattack » Sat Jan 27, 2018 11:38 am

Oh thanks, that makes sense. Maybe it could be more intuitive to just hide the gear icons for default actions?

Also, I encountered a problem: I overrides the default "click" operation with a custom action, now I can't find a way to put it back to "GeoTool" (I knew I can just copy it and use my copy to have the "click", but as you said in FAQ, this way I can't get the "official" update for this action automatically any more).

User avatar
DaveG
Flagfox Developer
Posts: 717
Joined: Wed Oct 03, 2007 9:06 pm
Location: Philadelphia, USA

Re: Cannot modify actions

Post by DaveG » Sat Jan 27, 2018 11:55 am

The gear icon exists to let you configure the hotclick and hotkey, the latter of which is unfortunately not supported at all by the now-mandatory WebExtension API, so I had to drop support for Firefox 57+. (the API only allows preset hotkeys, not any user-configuration of any kind) You can still set the hotclick though, which is what you're asking in the second part of your reply. Just click the gear icon for Geotool in the options (or doubleclick it) and set "Icon Click" to "Click" via the dropdown menu.

It'd be a bit of a mess if multiple things happened on clicking, so setting any action to "Click" also unsets it for whatever you previously had for it. You can set separate single, double, and triple clicks. Previous versions also supported middle-click, however, the new WebExtension API is limited and this feature had to be cut for Firefox 57+ support. (you may be sensing an unfortunately recurring pattern, there :( )

fireattack
Posts: 5
Joined: Sat Jan 27, 2018 7:20 am

Re: Cannot modify actions

Post by fireattack » Sat Jan 27, 2018 12:01 pm

>You can still set the hotclick though

I can't seem to be able to set it. Should I just "cancel" after selecting an icon click? Because as mentioned before, I can't click save as it's greyed out.

And it appears not saved:

Image

User avatar
DaveG
Flagfox Developer
Posts: 717
Joined: Wed Oct 03, 2007 9:06 pm
Location: Philadelphia, USA

Re: Cannot modify actions

Post by DaveG » Sun Jan 28, 2018 12:10 pm

Thanks for the screencap and sorry for not realizing there were two issues here, earlier. The inability to change the default action names & templates is intentional, but the save button is still supposed to work for saving the hotclick. It being greyed out is a bug in Flagfox 6.0.0, which I've now fixed for 6.0.1. There was also another bug here causing saved custom action hotclicks to not show in the edit dialog, which I've also fixed. Apparently, I didn't test this enough and nobody else noticed it in the beta. Sorry about that; the fixes will be in the next update, which should be available within the next few days. Thanks for reporting the issues.

fireattack
Posts: 5
Joined: Sat Jan 27, 2018 7:20 am

Re: Cannot modify actions

Post by fireattack » Sun Jan 28, 2018 11:45 pm

Great, thanks for all the hard work!

Locked