Flagfox 4.0beta5 stalling [FIXED]

Any feedback, suggestion, bug reports, problems....
Post Reply
User avatar
RobertJ
Posts: 8
Joined: Sun Aug 10, 2008 4:53 pm
Location: Chicago IL/Oconomowoc WI

Flagfox 4.0beta5 stalling [FIXED]

Post by RobertJ » Mon Feb 15, 2010 2:53 pm

I installed flagfox-4.0beta5 on FF3.6 on Mac 10.5.8 yesterday at 4:00 PM (CDT). Used for 15 minutes and all seemed OK.

This morning FF froze twice in less than five minutes. Fortunately I saved the old profile with the old version of Flagfox. I'm now running on the old profile. Will keep testing and report. Only have a few hours this AM.

Note, since this was a freeze and not a crash there was nothing in the crash reports.
Last edited by RobertJ on Mon Feb 15, 2010 4:10 pm, edited 1 time in total.
FF 3.6 - Mac OS10.5.8
Computers I've used: IBM 7094/UNIVAC 1108/IBM 360/DEC PDP11/DEC VAX-11 780/DEC VAXstation 8000/Sun SPARCstation 2/Mac from 1984 to 2010

User avatar
RobertJ
Posts: 8
Joined: Sun Aug 10, 2008 4:53 pm
Location: Chicago IL/Oconomowoc WI

Re: Flagfox 4.0beta5 stalling

Post by RobertJ » Mon Feb 15, 2010 3:39 pm

Been about an hour since I went back to the old profile with flagfox-3.3.20 and have had no freezes.
FF 3.6 - Mac OS10.5.8
Computers I've used: IBM 7094/UNIVAC 1108/IBM 360/DEC PDP11/DEC VAX-11 780/DEC VAXstation 8000/Sun SPARCstation 2/Mac from 1984 to 2010

User avatar
RobertJ
Posts: 8
Joined: Sun Aug 10, 2008 4:53 pm
Location: Chicago IL/Oconomowoc WI

Re: Flagfox 4.0beta5 stalling

Post by RobertJ » Mon Feb 15, 2010 4:37 pm

Been about two hours since I went back to the old profile with flagfox-3.3.20 and have had no freezes.
FF 3.6 - Mac OS10.5.8
Computers I've used: IBM 7094/UNIVAC 1108/IBM 360/DEC PDP11/DEC VAX-11 780/DEC VAXstation 8000/Sun SPARCstation 2/Mac from 1984 to 2010

User avatar
RobertJ
Posts: 8
Joined: Sun Aug 10, 2008 4:53 pm
Location: Chicago IL/Oconomowoc WI

Re: Flagfox 4.0beta5 stalling

Post by RobertJ » Mon Feb 15, 2010 4:47 pm

Just to complete info, these are the other add-ons I use (no issue with flagfox-3.3.20)

Adblock Plus 1.1.3
Add-on Compatibility Reporter 0.4.2
Autofill Forms 0.9.5.2
BBCodeXtra 0.2.5.6
BetterPrivacy 1.47
Clippings 3.1.1
CookieCuller 1.4
DOM Inspector 2.0.4
DownloadHelper 4.7
Extension Manager Extended 2.8.1
Favicon Picker 3 0.5
Form History Control 1.1.4
Greasemonkey 0.8.20100211.5
JavaScript Options 1.2.6
MR Tech About:About 2.4
Nightly Tester Tools 2.0.3
NoScript 1.9.9.47
Organize Status Bar 0.6.4
RefControl 0.8.13
SQLite Manager 0.5.11
Tamper Data 11.0.1
User Agent Switcher 0.7.2
Web Developer 1.1.8

.
FF 3.6 - Mac OS10.5.8
Computers I've used: IBM 7094/UNIVAC 1108/IBM 360/DEC PDP11/DEC VAX-11 780/DEC VAXstation 8000/Sun SPARCstation 2/Mac from 1984 to 2010

User avatar
DaveG
Flagfox Developer
Posts: 723
Joined: Wed Oct 03, 2007 9:06 pm
Location: Philadelphia, USA

Re: Flagfox 4.0beta5 stalling

Post by DaveG » Mon Feb 15, 2010 6:20 pm

Thanks for reporting this.
RobertJ wrote:This morning FF froze twice in less than five minutes.
Froze doing what? Was it just while you were browsing or after doing something specific in the options dialog? Please give me as detailed a description as you can.
RobertJ wrote:I installed flagfox-4.0beta5 on FF3.6 on Mac 10.5.8 yesterday at 4:00 PM (CDT).
...
Note, since this was a freeze and not a crash there was nothing in the crash reports.
Firefox 3.6 should be giving a dialog to offer to kill a stalled script in an extension (3.5 will not). Did it, and if it did, then what line of what file did it say was stalling? If it didn't, then this may be some Firefox bug I'm tripping over which will make it harder to diagnose.

Can you go back to your old profile with 4.0beta and reproduce the stall again?

I'm going to need more info here so I can look into this.

User avatar
RobertJ
Posts: 8
Joined: Sun Aug 10, 2008 4:53 pm
Location: Chicago IL/Oconomowoc WI

Re: Flagfox 4.0beta5 stalling

Post by RobertJ » Mon Feb 15, 2010 11:50 pm

Just got back home. Can you go back to your old profile with 4.0beta and reproduce the stall again? Will try tomorrow.

BTW - Froze doing what? I was just checking out mozillazine. It happened twice immediately after I launched FF.

Firefox 3.6 should be giving a dialog to offer to kill a stalled script in an extension (3.5 will not). Did it, No. I had to use my OS (Mac) to kill FF.
FF 3.6 - Mac OS10.5.8
Computers I've used: IBM 7094/UNIVAC 1108/IBM 360/DEC PDP11/DEC VAX-11 780/DEC VAXstation 8000/Sun SPARCstation 2/Mac from 1984 to 2010

User avatar
RobertJ
Posts: 8
Joined: Sun Aug 10, 2008 4:53 pm
Location: Chicago IL/Oconomowoc WI

Re: Flagfox 4.0beta5 stalling

Post by RobertJ » Tue Feb 16, 2010 4:06 pm

I was able to make it happen. I'm sending info to your email since I'm including a rather long hang report.
FF 3.6 - Mac OS10.5.8
Computers I've used: IBM 7094/UNIVAC 1108/IBM 360/DEC PDP11/DEC VAX-11 780/DEC VAXstation 8000/Sun SPARCstation 2/Mac from 1984 to 2010

User avatar
DaveG
Flagfox Developer
Posts: 723
Joined: Wed Oct 03, 2007 9:06 pm
Location: Philadelphia, USA

Re: Flagfox 4.0beta5 stalling

Post by DaveG » Tue Feb 16, 2010 9:09 pm

Just to update the status in this thread and post some more info for anyone else who may get this:

I've sent Robert a test build via email and thus far things look good. It has two optimizations that I was already working on due to a bug report via email from someone else, though thanks again to Robert here for being very helpful and thorough with his reporting and testing.

1) Saving the entire flagfox.actions JSON pref only takes 1ms for me, 100ms if I bloat up things with some test junk data. It shouldn't be a problem, but just in case it is for some others I've changed it to only refresh things for trivial changes to menu item showing and order and then save the pref on options dialog close (via any method, including Firefox exit). It's still fully saving things on edit/configure. This will reduce the number of times I have to parse everything, so if anyone was having issues with that it will be minimised, but it may just be a fairly small performance win.

2) I was lazily precaching favicons on each refresh of the menu or options dialog under the assumption that caching and the garbage collector would handle things nicely. It doesn't seem to. It'll now only precache the one time it needs to for the first menu load. This may mean that if the menu gets something new due to a Mozilla Weave sync there'll be a delay in showing those favicon(s) when you open the menu, but this is an edge case. This also fixes a few other issues, which may present as a stall on another OS but for me just meant broken favicons and a rare instance of a crash with a threading error if I really went nuts and toggled the favicons all on/off dozens of times in a row.

If anyone reads this and still gets anything I described above in a version after 4.0beta5, then by all means please tell me and I'll look into it. Otherwise, I'm hoping this is now fixed.

I'll hopefully get a new version up with these fixes soon. I'm trying to avoid a 6th beta, so I can hopefully get as much updated localization as I'm going to get and post a 4.0 final soon. I'll post to both the beta channel and the main channel so that beta testers can update to test the final version (a release candidate, really) first. It'll be a little bit of wait until everyone else gets it, as an AMO editor will need to do a code review first.

Post Reply